adding files related to NOA GFS poc#1824
adding files related to NOA GFS poc#1824balit-raibot wants to merge 23 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @balit-raibot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational data and configuration for a Proof of Concept (PoC) to integrate NOAA Global Forecast System (GFS) data into the system. It includes the raw GFS data, the necessary metadata and mapping files to process this data, and the resulting transformed output, along with the corresponding statistical variable definitions and schema. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds new files for importing NOAA GFS data as a proof-of-concept for Data Commons. While this is a valuable addition, I've identified several critical and high-severity issues in the generated files and configurations that should be addressed to ensure the data is imported correctly and the process is robust. Key issues include hardcoded values leading to data precision loss, incomplete and fragile TMCF definitions, malformed data in the output CSV, and stylistic issues in the MCF files.
…to noa_gfs_poc
3 participants
Adding GFS Data of NOA for Data Commons POC